Static analysis - Githubissues

netromdk / slacker

Slacker - Easy access to the Slack API and admin of workspaces/teams.

MIT License

14 stars 0 forks source link

Static analysis #101

Closed netromdk closed 6 years ago

netromdk commented 6 years ago

Depends on #100.

Changes proposed in this pull request:

Added static analysis using vulture
make static_analysis runs vulture with our custom whitelist at ".vulture_whitelist.py"
make check also runs make static_analysis, which means Travis also does
Removed unused code
Marked required but unused arguments to not give false positives
Updated "CONTRIBUTING.md" about adding new commands to vulture whitelist