netromdk / slacker

Slacker - Easy access to the Slack API and admin of workspaces/teams.
MIT License
14 stars 0 forks source link

Build/dockerfile #111

Closed 0verbyte closed 5 years ago

0verbyte commented 5 years ago

Changes proposed in this pull request:

The reason for .dockerignore is to avoid sending these files to the Docker engine which will be included in the resulting Docker image, but aren't providing any direct usages to slacker except bloat in the image size. Without .dockerignore file the resulting image can be 20MB larger, mostly depending on the size of the local pycache files, if a virtualenv exists and .git directory.

netromdk commented 5 years ago

Nice job. This all works great! It would be nice with a script that wraps

docker run -v $(pwd):/root/ -it slacker:local

So you don't have to do long lines like

docker run -v $(pwd):/root/ -it slacker:local --init

etc. Could be in a file named "docker_run.sh"?

0verbyte commented 5 years ago

Added the script. I don't believe we need the --init flag because slacker is PID 1 and will receive the signals directly.

netromdk commented 5 years ago

The --init flag was just an example of one of our arguments for slacker. I meant for the script to take all arguments and pass to the running slacker instance inside Docker. So that you could do like ./docker_run.sh files.list -c 10, for instance.