search

netromdk / slacker

Slacker - Easy access to the Slack API and admin of workspaces/teams.
MIT License
14 stars 0 forks source link

Allow only ASCII commands and aliases #23

Closed netromdk closed 6 years ago

netromdk commented 6 years ago

Should we only allow ASCII commands and aliases? At least we should not allow

,;:|&%#"'/\()[]{}=?+-_´`!$§<>

right? It would be easier to say we only allow [\w\d\.] (case-insensitive regex).

0verbyte commented 6 years ago

Should be fine. I am trying to think of something where it would be helpful to use <> mutually exclusive. Perhaps a command could be give me the files where the date is greater than date. But then the command could easily just handle the date range logic like slacker files.list <start> <end> or slacker files.list <start>, where start/end are dates to do searching and we don't need logic operators in the command syntax itself, but rather implement in the underlying command in code.

tldr; I think [\w\d.] case insensitive regex is sufficient.

netromdk commented 6 years ago

Yeah, I agree that we can just handle those things as arguments in the specific commands.