netrunner-rolling / 2018.01

All things related to the 2018.01 release
1 stars 0 forks source link

Menu: switching to simplemenu has empty "Favorites" #33

Closed star-buck closed 6 years ago

star-buck commented 6 years ago

on beta2 i think there were Favorites when switching to simplemenu.

NuLogicSystems commented 6 years ago

It looks like kactivitymanager is now managing favorites, our scripts are writing the favorites and they are getting imported into kactivitymanager, along with the default favorites. This might require the simplemenu source code to be updated for this change. screenshot_20180112_032503

star-buck commented 6 years ago

It worked in beta2? Can you check if the simplemenu is also the latest version released on store.kde.org?

On Jan 12, 2018 00:24, "James Kittsmiller" notifications@github.com wrote:

it looks like kactivitymanager is now managing favorites, Our scripts are writing the favorites and they are getting imported into kactivitymanager. This might require the simplemenu source code to be updated for this change.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/netrunner-rolling/2018.01-issues/issues/33#issuecomment-357173216, or mute the thread https://github.com/notifications/unsubscribe-auth/AAzRhoszmrYSlYv1m2ntxYnOzdTLoTHvks5tJxa7gaJpZM4Rb4Li .

NuLogicSystems commented 6 years ago

I can certainly check.

NuLogicSystems commented 6 years ago

Yes, this does need an updated my package.

NuLogicSystems commented 6 years ago

NOTE: Switching menus now adds back in the upstream KDE default favorites. Needs to be looked into.

star-buck commented 6 years ago

thats fine for now.