Add --config-file support for security - Githubissues

netscaler / netscaler-adc-metrics-exporter

Export metrics from Citrix ADC (NetScaler) to Prometheus

89 stars 32 forks source link

Add --config-file support for security #2

Closed colinmkeith closed 5 years ago

colinmkeith commented 5 years ago

Add support for reading from a config.yaml file so that the password and other (non-required) options are read from the config file. This is important for the password as it avoids specifying on the CLI or as an env var, improving security.
Include example config.yaml
Define choices for secure
Treat not opening exporter port as fatal
Description for --port clarifies what it is for.

colinmkeith commented 5 years ago

Add support for --config-file option so that password (and username) are not visible to other users of the box via ps (either on cmdline or via env var)
Define choices for secure
Treat not being able to open the exporter listener port as fatal
--log-file, --metrics-json CLI support
.gitignore config.yaml files to avoid information leaking