search

netscaler / netscaler-adc-metrics-exporter

Export metrics from Citrix ADC (NetScaler) to Prometheus
89 stars 33 forks source link

Gauges? #38

Closed rafaelpirolla closed 3 years ago

rafaelpirolla commented 3 years ago

https://github.com/citrix/citrix-adc-metrics-exporter/blob/15f435bad8b3bef42367caf4be5b954a9d7b1415/metrics.json#L5

daystoexpiration also?

Shouldn't this be a gauge as it can go down?

aroraharsh23 commented 3 years ago

Will verify this and update these system counters.

aroraharsh23 commented 3 years ago

To correct: 'disk1avail' is a value, it can go up/down as a counter.. is it not changing? An entity in 'system' Gauge meant values in percentage terms.

We already have usage Gauges: ["disk1perusage", "citrixadc_var_partition_used_percent"], ["disk0perusage", "citrixadc_flash_partition_used_percent"]

'disk1avail' percentage is just the remaining of what's used. Again, 'daystoexpiration' can go up/down as a counter, percentage Gauge is N.A.

Let me know if the understanding is correct or your requirement is different.

aroraharsh23 commented 3 years ago

Can we close this or still some doubt. here?

rafaelpirolla commented 3 years ago

I think that any metric that can go down is a gauge. If you set disk1avail as a prometheus counter some promql functions would miss behave, I think. But you can close this if you want, it's easy to fix it in the client side.