[BUG FIX] remove duplicate apiVersion entry at rbac.yaml

[janlauber]

Fellow Citrix Team

I've been facing the following error when installing the citrix-ingress-controller via the helm-controller from flux2:

helm-controller  Helm install failed: error while running post render on files: map[string]interface {}(nil): yaml: unmarshal errors:
  line 17: mapping key "apiVersion" already defined at line 3

So I started debugging your Helm chart, because other ones from other projects were applied successfully. I figured out, that you have a duplicated entry in the rbac.yaml files of the both ingress-controller helm charts:

• https://github.com/citrix/citrix-helm-charts/blob/8998c1e30d171c286f8d92611bbbe65d280012a1/citrix-ingress-controller/templates/rbac.yaml#L71
• https://github.com/citrix/citrix-helm-charts/blob/8998c1e30d171c286f8d92611bbbe65d280012a1/citrix-cpx-with-ingress-controller/templates/rbac.yaml#L71

I've deleted these lines and tested it for myself, and now it's applying perfectly. Please merge my PR into your upstream helm charts to fix this issue.

Thank you very much and kind regards Jan Lauber Signed-off-by: Jan Lauber jan.lauber@protonmail.ch

[svengerber]

Facing the same issue. This fix seems to resolve the issue.

[priyankash-citrix]

Thanks @janlauber. This change was required in other files as well apart from those which were there in your PR, we have fixed this in all the charts. The fix is available in the latest chart version. Please use the latest charts and let us know if there is any issue.

[janlauber]

Thanks @priyankash-citrix I tested it and it's working now. Thanks for changing it.

BR, Jan