netscaler / netscaler-helm-charts

NetScaler helm charts
https://github.com/netscaler/netscaler-helm-charts
Apache License 2.0
21 stars 31 forks source link

Make it possible to override image repository/registry in citrix-ingress-controller #132

Closed ONordander closed 1 year ago

ONordander commented 2 years ago

Hi. Currently it's not possible to override only the image repository or registry, it's only possible to override the full image reference. In a setting where the images are mirrored it would be great if we could just specify a different repository but use the default chart tag like so:

values.yaml

image:
  registry: quay.io
  repository: citrix/citrix-k8s-ingress-controller
  tag: 1.26.7 

And then we could override it:

override-values.yaml

image:
  registry: myregistry.com
  repository: mirrors/citrix/citrix-k8s-ingress-controller

See an example here https://github.com/bitnami-labs/sealed-secrets/blob/main/helm/sealed-secrets/values.yaml

raviganapatp commented 1 year ago

@ONordander we have added this feature now. You can now override only the image repository or registry or tag OR also the full image reference from the values.yaml

# Citrix Ingress Controller config details
imageRegistry: quay.io
imageRepository: citrix/citrix-k8s-ingress-controller
imageTag: 1.27.15
image: "{{ .Values.imageRegistry }}/{{ .Values.imageRepository }}:{{ .Values.imageTag }}"