search

netscaler / netscaler-helm-charts

NetScaler helm charts
https://github.com/netscaler/netscaler-helm-charts
Apache License 2.0
21 stars 31 forks source link

Resolved templating issue with cic disabled #173

Closed BobVanB closed 7 months ago

BobVanB commented 8 months ago 
cic:
  required: false

gives a: duplicated resource error

priyankash-citrix commented 7 months ago

Hi @BobVanB , Thanks for pointing out the issue in the template of Helm chart. We have released the correct fix for this issue and it is available in our latest Helm Charts. Please use them and let us know if there are any further queries.

BobVanB commented 7 months ago

@priyankash-citrix i proposed the fix, but have not tested it with cic.required=True. Can you please make shure the fix was correct?

priyankash-citrix commented 7 months ago

Hi @BobVanB, the issue reported by you was there but the fix done in your PR was not the correct fix for that issue. Moreover this needed to be fixed in other helm charts as well, that is why I have checked-in the correct fix for the issue in all the helm charts. And the fix available in the latest helm charts should work for both cic.required=True and cic.required=False.

BobVanB commented 7 months ago

Glad to know, thank you.