search

netscaler / nitrox

Configure Citrix Netscaler Loadbalancing for container platforms
Apache License 2.0
30 stars 14 forks source link

Some features + some fixes #4

Closed darkweaver87 closed 3 months ago

darkweaver87 commented 8 years ago

Hello,

Here are some non breaking modifications to make it work on an up to date mesos/marathon environment. I also added some features to make it compliant with our naming conventions :-) Please accept those.

Rémi

chiradeep commented 8 years ago

I'm on vacation right now, will test and merge next week

darkweaver87 commented 8 years ago

ok no problem :-)

chiradeep commented 8 years ago

Hi, this doesn't work (due to the base64 encoding change). I can't figure out why this (base64 enc) is required.

darkweaver87 commented 8 years ago

Hello,

Sorry for late answer. This is because I didn't manage to start the application with marathon with a APP_INFO containing complexe json. But I think I'll remove this and make APP_INFO be able to be loaded from a json file.

Rémi

wallnerryan commented 7 years ago

cc @darkweaver87 @chiradeep is this project still valid? Looking to use this against mesos 1.9 and citrix 10.5

chiradeep commented 7 years ago

Tested against NetScaler 11, I believe but should be compatible. But please raise issues if you see them.

Sent from my iPhone

On Apr 13, 2017, at 8:21 AM, Ryan Wallner notifications@github.com wrote:

cc @darkweaver87 @chiradeep is this project still valid? Looking to use this against mesos 1.9 and citrix 10.5

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

wallnerryan commented 7 years ago

@chiradeep thanks, We have MPX/VPX. Also is there a reason this PR was not merged?

chiradeep commented 7 years ago

Didn't work

Sent from my iPhone

On Apr 13, 2017, at 8:30 AM, Ryan Wallner notifications@github.com wrote:

@chiradeep thanks, We have MPX/VPX. Also is there a reason this PR was not merged?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

darkweaver87 commented 7 years ago

Hello wallnerryan,

Yes, we are using on our production systems since months. We have NS 10.5 and mesos 1.1.0.

Rémi

wallnerryan commented 7 years ago

@darkweaver87 Thanks. Just to clarify, you are running the master branch with " NS 10.5 and mesos 1.1.0"?

We are running mesos 1.9, so i suspect some issues using this, if we find it useful and produce any fixes we will report/help contribute

mikkodisini commented 7 years ago

@adolforod Do you mind sharing your use case? I am in the PM team with NetScaler.

darkweaver87 commented 7 years ago

@wallnerryan Well yes, I'm running the master branch, this pull request included: https://github.com/Cdiscount/nitrox But from what I see, I'll have to include last fixes from chiradeep

darkweaver87 commented 3 months ago

Cleaning some old PR, I don't think still need this.