netsec-ethz / rains

RAINS (Another Internet Naming Service)
Apache License 2.0
9 stars 11 forks source link

Update SCION Dispatcher-less #243

Closed juagargi closed 4 months ago

juagargi commented 4 months ago

The new scionproto codebase upstream uses a thin dispatcher (dispatcher-less mode). Adapt RAINS to it. Adapt CI.


This change is Reviewable

martenwallewein commented 4 months ago

Looks good to me! Again, thanks Juan for tackling this!

I have one question out of curiosity: what is the intention behind the go version 1.21.10 and the toolchain 1.21.11, is it intended that these differ by one patch version?

juagargi commented 4 months ago

Those came directly by using go get scionproto-new and go mod tidy. I have not worried too much about them though. If you find out what they do and why they ended up there, please let us know :smiley: In scionproto's go.mod they only declare the version of go

go 1.21.10

But no mention to the toolchain. BTW, the last version of go 1.21 is 1.21.11. That might be the reason of the toolchain version being one higher up than th go one? Idk.