search

netsec-ethz / scion-apps

Public repository for SCION applications
Apache License 2.0
20 stars 43 forks source link

govendor list +o returns non-empty #57

Closed juagargi closed 5 years ago

juagargi commented 5 years ago

When running govendor list +o on current master, it returns some missing libraries:

  m github.com/jtolds/gls                            
  m github.com/smartystreets/assertions              
  m golang.org/x/image/font                          
  m golang.org/x/image/font/basicfont                
  m golang.org/x/image/math/fixed                    
  m roughtime.googlesource.com/go/client/monotime    
  m roughtime.googlesource.com/go/config             
  m roughtime.googlesource.com/go/protocol

Some of them come from our roughtime app, but I don't know if all of them do. Find out why we have these missing libraries and modify consequently our vendor.json

mwfarb commented 5 years ago

I can speak for the golang.org/x/image libs. They are for test image servers for webapp. I can supply the proper versions

mwfarb commented 5 years ago

Patch attached. add-imgserver-test-vendor-libs.patch.txt

chaehni commented 5 years ago

I don't really trust this govendor tool on that. For example, govendor list +u shows a couple packages which are apparently unused. However, removing them with govendor remove +u and then trying to compile the apps fails because of missing dependencies.

juagargi commented 5 years ago

The entries regarding roughtime were real. I have created PR #60 fixing roughtime (this vendor plus other small things). After that PR we only have this govendor list +o :

  m github.com/jtolds/gls                  
  m github.com/smartystreets/assertions

We have to decide if we ignore them and close this PR, or do something.

juagargi commented 5 years ago

The latest commits in PR #60 solve this issue. Now govendor list +o is empty.