search

netsiphd / netrd

A library for network {reconstruction, distances, dynamics}
https://netrd.readthedocs.io/en/latest/
MIT License
166 stars 43 forks source link

Two small fixes and black file auto-formatting. #328

Closed djpasseyjr closed 1 year ago

djpasseyjr commented 1 year ago

Hi, I ran into a bug in the continuous time Lotka-Volterra model and I fixed it. I ran the black auto-formatter as well. Additionally, when I ran the tests I caught a depreciated networkx method and fixed it: nx.from_scipy_sparse_matrix -> nx.from_scipy_sparse_array.

As far as I can tell all tests pass! DJ

sdmccabe commented 1 year ago

@djpasseyjr Thanks for this!

@leotrs CI issue seems to be https://github.com/actions/setup-python/issues/544#issuecomment-1320091667.

My instinct is to just drop 3.6; it's end-of-life anyway. (And we should add 3.10/3.11 coverage.) Sound good to you?

leotrs commented 1 year ago

Affirmative.

On Tue, Mar 28, 2023, 6:53 PM Stefan McCabe @.***> wrote:

@djpasseyjr https://github.com/djpasseyjr Thanks for this!

@leotrs https://github.com/leotrs CI issue seems to be actions/setup-python#544 (comment) https://github.com/actions/setup-python/issues/544#issuecomment-1320091667 .

My instinct is to just drop 3.6; it's end-of-life anyway. (And we should add 3.10/3.11 coverage.) Sound good to you?

— Reply to this email directly, view it on GitHub https://github.com/netsiphd/netrd/pull/328#issuecomment-1487280063, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAILYAECZUYPZHQ5K6FUFHLW6MJRFANCNFSM6AAAAAAWJYVGQI . You are receiving this because you were mentioned.Message ID: @.***>