netson / l4gettext

Package to add Gettext support to Laravel 4 applications
61 stars 8 forks source link

Config views directory #14

Closed ghislainf closed 9 years ago

ghislainf commented 10 years ago

Hello,

Thanks for this package. Can you use the Config::get('view.paths') without redifined the view directory in your config package. It's more flexible.

My views directory is on root project. And your call bellow forces me to extends your package.

$views_folder = app_path() . DIRECTORY_SEPARATOR . $this->option('views_folder') . DIRECTORY_SEPARATOR;

Cheers :beer:

netson commented 10 years ago

Which file and line number are you referring to?

ghislainf commented 10 years ago

class ExtractCommand line 54

netson commented 9 years ago

Sorry it took me forever to get back to you on this issue, it's been crazy hectic here.

I was just reviewing your request and was wondering if you couldn't just use the additional_input_folders config option?

Here's the documentation on that option:

        /**
         * provide any additional input folders that you would like to have scanned and processed
         * the main 'input_folder' directove is commonly used for your (compiled) templates folder containing
         * the majority of your translation strings, but you can use this config option to set
         * additional folders, for example one containing your error messages embedded in your class file.
         *
         * this directive looks for all .php files and the folder is relative to the applications' root [/]
         * folder, using laravel's base_path() function. Files in these directories will NOT be compiled
         * before extracting the the language strings
         *
         * the default is an an empty [array()]
         */
        'additional_input_folders' => array(),
netson commented 9 years ago

Assumed solved; closing