search

netson / l4gettext

Package to add Gettext support to Laravel 4 applications
61 stars 8 forks source link

on some systems we need to change LANGUAGE variable #16

Open wodabr opened 10 years ago

wodabr commented 10 years ago

Hi,

thanks for excellent pice of software :)

I've spend hours to figure out why this won't work on my box, it seems that on some systems we also need to change LANGUAGE variable - (someone had similar problem - http://php.net/manual/en/ref.gettext.php#29799)

netson commented 10 years ago

Hey! Thanks for the pull request; on what systems have you tested this modification? I want to make sure this doesn't throw any errors for existing users.

wodabr commented 10 years ago

I've tested this on

1) CentOS release 6.5 - PHP 5.5.13 - lighttpd/1.4.34 2) Ubuntu 12.04.4 LTS - PHP 5.5.12-2 - nginx/1.6.0

netson commented 10 years ago

And did you have the issue on both systems as well? Do you know what causes this behavior? I scanned though the comments on the PHP website from your link, but couldn't really determine which conditions lead to this issue.

I'll run some tests on my box this weekend with your code, and pull in your changes if all works well! Thanks for contributing! :+1:

wodabr commented 10 years ago

nope, I forgot to mention that only centos is giving me hard time :) on my dev box (ubuntu) everything works fine. and no I don't know root cause of this behavior ;(

netson commented 10 years ago

Alright, thanks for the info. I usually work on Ubuntu boxes as well (12.04 and 14.04) so I'll see if I can whip up a virtual CentOS box to do some testing! Keep you posted! :)

netson commented 10 years ago

Hey, haven't forgotten about this issue, I've just been crazy busy. Hope to get around to it this weekend. Sorry for the delay!