search

netsuitephp / netsuite-php

NetSuite PHP API Client with namespaces and autoloading
Other
189 stars 85 forks source link

Updated the endpoint to 2021_1 #109

Closed FSElias closed 3 years ago

neclimdul commented 3 years ago

that's a lot of commits to import the classes :(

nikolaynesov commented 3 years ago

@neclimdul the commits can be squash-merged. Is there any other reason why it's delayed?

jrebs commented 3 years ago

@neclimdul the commits can be squash-merged. Is there any other reason why it's delayed?

Mostly the same reasons everything is delayed these days, lots of stuff going on in the world; and the when the PR contains 20 or 30 commits and many more files changed, I assume I'm going to need to set aside some proper time to give it a close review and decide on it. So, it has kept getting pushed behind other tasks because of that. That being said, there are a few changes to be made here and then I can indeed squash it in, but I do recommend people try to PR something that has already been cleaned up, as it's almost sure to get processed quicker in projects of any size (I realize you are not the author).

neclimdul commented 3 years ago

yeah, didn't really start reviewing because the commit history was big and had some red flags. Easiest way to get something merged fast, make the patch/merge request digestable and clean. :-D

jrebs commented 3 years ago

@FSElias Thanks for the updates, Fady. I'll get this resolved today.