search

netsuitephp / netsuite-php

NetSuite PHP API Client with namespaces and autoloading
Other
189 stars 85 forks source link

Allow broader versions for psr/log #154

Closed kissifrot closed 10 months ago

kissifrot commented 1 year ago

Most other packages support 1/2/3.x versions

neclimdul commented 1 year ago

Did you check if the logger is compatible with the type hint changes in 3?

tumispro commented 1 year ago

This would be really useful, as it's now incompatible with a lot of Laravel applications.

neclimdul commented 1 year ago

Seems fine but waiting on confirmation of testing the breaking type hint changes in the PSR-3 v3 release.

chumanfu commented 12 months ago

I am also blocked by this. We are using Monolog in our app which requires psr/log ^2.0 so currently am unable to upgrade.

chumanfu commented 12 months ago

closes #159

lucashodge commented 11 months ago

Looks like this is all good, is it possible to get this merged? Thanks all.

ryanwinchester commented 11 months ago

@lucashodge @chumanfu @kissifrot did either of you test this branch to confirm it works?

that's all @neclimdul wanted to confirm and nobody has answered :P

Seems fine but waiting on confirmation of testing the breaking type hint changes in the PSR-3 v3 release.

alex-volga commented 10 months ago

+

lucashodge commented 10 months ago

@ryanwinchester @neclimdul sorry my previous comment wasn't clear then. All working fine on Drupal 10 for me with psr/log:3.0.0 . I am not sure if further more specific testing is required? I think a lot of people have just been forking this repo and applying the change but it would be good to use the OG repo again. Thanks for all your work.

ahfeel commented 10 months ago

6 months to get such a simple diff tested and merged, really ? ...

jrebs commented 10 months ago

6 months to get such a simple diff tested and merged, really ? ...

The author dropped the PR and then went completely silent. Never responded to any requests for confirmations, etc. It took about 6 months to get explicit verification that this had been tested against potential breaking combinations. Add to that the fact that this isn't a "something is broken in the current version" PR and instead is an "it would be nice if..." PR, yeah the urgency might not be really high for maintainers to do the leg work of getting a PR merged.

That being said, it's merged. Merry Christmas. 🎄🎁

kissifrot commented 10 months ago

Hello,

Sorry for the vanish, I had a car crash, thus I had different priorities than this PR 😅

Thanks @jrebs for the merge and Merry Christmas too 🙂 🎄🎁

ahfeel commented 10 months ago

Thank you guys, hope you totally recovered @kissifrot !

Merry xmas !