nette-intellij / intellij-neon

Neon language support for PhpStorm / IntelliJ IDEA
http://plugins.intellij.net/plugin/index?pr=webide&pluginId=7060
MIT License
96 stars 43 forks source link

Closing Project dialog is shown for 30+seconds with Neon plugin enabled #74

Closed PhilETaylor closed 1 year ago

PhilETaylor commented 1 year ago

Describe the bug When switching projects or closing phpStorm the Closing Project dialog is shown for 30+ seconds and hangs the process

ScreenShot-2023-04-06-18 09 11

Environment (please complete the following information):

To Reproduce Steps to reproduce the behavior (or attach video):

  1. Open a project
  2. Switch to another project using cmd+o and select project - or just quit phpStorm
  3. See that the closing dialog shows for a very very long time

Additional context Disabling the Neon plugin fixes the problem

honzavaclavik commented 1 year ago

Same problem here

honzavaclavik commented 1 year ago

@mesour Any update?

mesour commented 1 year ago

I found the problem. I will make new version until the end of the week at most.


Info about solution:

Simplest workaround - check for the com.intellij.openapi.progress.ProgressManager#checkCanceled in a loop. A better approach - to use other means of delaying the notification

class MyActivity : StartupActivity.Background {
  override fun runActivity(project: Project) {
    val alarm = Alarm(Alarm.ThreadToUse.SWING_THREAD, project)
    alarm.addRequest({ doStuff() }, 60000)
  }
}

<postStartupActivity implementation="com.plugin.MyActivity"/>

honzavaclavik commented 1 year ago

Please fix it 😇

badpenguin commented 1 year ago

I found the problem. I will make new version until the end of the week at most.

Any news? Same problem here :)

mesour commented 1 year ago

Fixed in 0.5.4 it will be available in 2 business days

honzavaclavik commented 1 year ago

0.5.4 Works for me, thanks