search

nette / bootstrap

🅱 The simple way to configure and bootstrap your Nette application.
https://doc.nette.org/bootstrap
Other
668 stars 36 forks source link

Addeded method to register Nette\DI\Config\IAdapter #39

Closed sallyx closed 7 years ago

sallyx commented 9 years ago
JanTvrdik commented 9 years ago

I think that it is better to extend Nette\Configurator and override createLoader in your application. The use-case for this is IMHO too narrow.

fprochazka commented 9 years ago

@JanTvrdik which is problematic, if you wanna write an extension that adds xml adapter.

dg commented 9 years ago

addAdapter should be called in onCompile and it is imho late for adding new loaders.

sallyx commented 9 years ago

So, what is the result? Should I extend Nette\Configurator and relay on protected method not to be changed/removed in the future?

f3l1x commented 7 years ago

Any progress @sallyx? What should we do with this PR? @TomasVotruba @dg @JanTvrdik

sallyx commented 7 years ago

I have no idea. You should accept it or refuse it.

TomasVotruba commented 7 years ago

I don't get the feature and use case. Could you elaborate on small example?

dg commented 7 years ago

This should be solved this way https://github.com/nette/bootstrap/pull/39#issuecomment-121298933, closing.