search

nette / database

💾 A database layer with a familiar PDO-like API but much more powerful. Building queries, advanced joins, drivers for MySQL, PostgreSQL, SQLite, MS SQL Server and Oracle.
https://doc.nette.org/database
Other
513 stars 108 forks source link

Bug in getter typing ?\PDOstatement #266

Closed matak closed 3 years ago

matak commented 4 years ago

https://github.com/nette/database/blob/b5677ad6d99efb5526d308b767260f921d93000e/src/Database/ResultSet.php#L91

as the definition of pdoStatement is

/* @var \PDOStatement|null / private $pdoStatement;

https://github.com/nette/database/blob/b5677ad6d99efb5526d308b767260f921d93000e/src/Database/ResultSet.php#L27

there should be fix like this?

from public function getPdoStatement(): \PDOStatement

to public function getPdoStatement(): ?\PDOStatement