search

nette / database

💾 A database layer with a familiar PDO-like API but much more powerful. Building queries, advanced joins, drivers for MySQL, PostgreSQL, SQLite, MS SQL Server and Oracle.
https://doc.nette.org/database
Other
502 stars 107 forks source link

jetbrains/phpstorm-attributes dev-master vs 1.0 #302

Closed lukaspijak closed 11 months ago

lukaspijak commented 11 months ago

Version: v3.1.8

Bug Description

Hi, if you have installed jetbrains/phpstorm-attributes in version 1.0, you can not install nette/database v3.1.8

Steps To Reproduce

image

Possible Solution

You can add to composer.json:

"jetbrains/phpstorm-attributes": "*",
spaze commented 11 months ago

Hi, similar problem when my composer.json doesn't specify minimum-stability (and stable is then used as the default):

- nette/database v3.1.8 requires jetbrains/phpstorm-attributes dev-master -> found jetbrains/phpstorm-attributes[dev-master] but it does not match your minimum-stability.

JanTvrdik commented 11 months ago

jetbrains/phpstorm-attributes should be a dev-dependency, it's not needed at runtime.

dg commented 11 months ago

@JanTvrdik won't PhpStan then report errors?

JanTvrdik commented 11 months ago

It should work just fine. Having dev-only attributes is valid pattern. For example #[Sealed] attribute from https://github.com/jiripudil/phpstan-sealed-classes is also suggested to be installed as dev-dependency.

dg commented 11 months ago

fixed