search

nette / latte

☕ Latte: the safest & truly intuitive templates for PHP. Engine for those who want the most secure PHP sites.
https://latte.nette.org
Other
1.13k stars 109 forks source link

UserNotice: The assignment in the ... looks like an error. #258

Closed patrik-owly closed 3 years ago

patrik-owly commented 3 years ago

Version: v2.10.1

Bug Description

UserNotice: The assignment in the ... looks like an error. Assigning to $primaryString variable which is used immediately on next line ($iePrimary === $primaryString)

Steps To Reproduce

{include #body-row,
    $recordVariable => $record,
    primaryString => ($primaryString = ($record |primaryToString)),
    isInlineEdited => $hasInlineEdit && $iePrimary === $primaryString
}

Same issue as in https://github.com/uestla/TwiGrid/issues/40

dg commented 3 years ago

fixed

tprochazka commented 3 years ago

Weird that it is even worse in 2.10.1, it still crashing and also shows the wrong line number. I'm using uestla/twigrid in version "12.0.0"

image

dg commented 3 years ago

Did you try master?

tprochazka commented 3 years ago

No, just 2.10.1. I tested it now with latte/latte (v2.10.x-dev a5946ee): Cloning a5946ee1a7 from cache And it is really fixed. Thanks!