search

nette / php-generator

🐘 Generates neat PHP code for you. Supports new PHP 8.3 features.
https://doc.nette.org/php-generator
Other
2.11k stars 138 forks source link

3.3.0 contains BC Break #48

Closed paveljanda closed 4 years ago

paveljanda commented 4 years ago

Version: 3.3.0

Bug Description

When updating version 3.2.3 -> 3.3.0, nette/di vendor throws an err:

Fatal error: Uncaught Nette\MemberAccessException: Call to undefined static method Nette\PhpGenerator\Helpers::createObject(). in /Users/paveljanda/www/gamee/apps/admin/vendor/nette/utils/src/Utils/ObjectHelpers.php:78

Nette DIC is creating instances using following call:

Nette\PhpGenerator\Helpers::createObject

Steps To Reproduce

Upgrade nette/php-generator 3.2.3 -> 3.3.0 and try to build a DIC possibly using phpstan command. PHPstan version: 0.11.19 (Nette\PhpGenerator\Helpers::createObject)

Expected Behavior

No BC Breaks when updating minor version

Possible Solution

Maybe releasing a 4.0.0 with BC breaks or leaving the minor release without BC Breaks

Versions diff: https://github.com/nette/php-generator/compare/v3.2.3...v3.3.0

paveljanda commented 4 years ago

☝️Nice, thanks