WIP: add php8 support - Githubissues

ChrisB9 commented 4 years ago

bug fix & new feature for php 8.0
BC break? yes (all changes here will break support for tests below 7.4, might require a 4.0)

(using php 8.0alpha3 with this container: https://hub.docker.com/r/chrisb9/php8-nginx-xdebug)

I started on the new php 8.0 features and realized, that a bunch of things won't work anymore with the new version.

Todos:

[x] Union-Type Support
[ ] Exceptions in arrow-functions and after nullables
[x] Attribute-Support (unable to implement until syntax is clear)
[x] comma-support at the end of method-signatures
[x] constructor property promotion (that one is super useful for generated classes)
[x] static return type
[x] mixed return type

(i hope i didnt forget anything?)

This is still a draft, because I still have issues fixing this problem here: -- FAILED: Nette\PhpGenerator generator. | ClassType.from.phpt Exited with error code 255 (expected 0) E_DEPRECATED: Required parameter $c follows optional parameter $a

dg commented 4 years ago

Great! I fixed tests so they all pass on PHP 8 nightly https://travis-ci.org/github/nette/php-generator/jobs/713438049

ChrisB9 commented 4 years ago

Thanks, that's perfect. I'll merge it back into my branch. Since union types are currently the only supported in phpstorm, I'll start with that.

ChrisB9 commented 4 years ago

Should we use this and create a new version of php-generator and drop therefore php 7.1 support or do we try to keep compatibility?

dg commented 4 years ago

It would definitely be better to try to maintain compatibility.

dg commented 3 years ago

PHP 8 support is done in v3.5

nette / php-generator

WIP: add php8 support #66