nette / schema

📐 Validating data structures against a given Schema.
https://doc.nette.org/schema
Other
886 stars 26 forks source link

Prevent merging default array values by default #31

Closed colinodell closed 3 years ago

colinodell commented 3 years ago

This is an alternative to #28 which always prevents default array values from being merged with user-provided ones.

colinodell commented 3 years ago

@dg As a project maintainer myself, I really hate to be that guy, but... do you have a rough ETA on if/when this change (or something like it) might be released? This functionality is going to be essential for league/commonmark's upcoming 2.0 release so I'm trying to plan whether we should wait on a nette/schema release that doesn't merge defaults, or if we should forge ahead with some kind of alternate approach for now (maybe a fork or compatibility layer or something like that).

I completely understand that you have your own personal and professional priorities, so the last thing I want to do is pressure you into making a decision or doing extra work, but any high-level guidance you could offer me would be much appreciated!

dg commented 3 years ago

I really hate to be that guy

:-D

I've had a lot of work to update all my libraries to PHP 8 last month, and now I'm ready to finish new releases, so the new version will be really soon.

colinodell commented 3 years ago

That works for me. I'll keep an eye out for that release whenever it lands - no rush here. Thanks for the quick response and for the work you're putting into this - I greatly appreciate both!

And I do know this PR has fallen out of date, so let me know if you'd like me to rebase/recreate it - happy to do so if it helps.