search

nette / tester

Tester: enjoyable unit testing in PHP with code coverage reporter. 🍏🍏🍎🍏
https://tester.nette.org
Other
453 stars 71 forks source link

DomQuery nested parentheses #235

Closed trejjam closed 9 years ago

trejjam commented 9 years ago

Hi,

I try to use Tester\DomQuery::css2xpath('input[name=container[item]]') to test Nette\Forms, but css2xpath response: //input[@name='container[item'] instead of //input[@name='container[item]'].

I think problem is in regex here: https://github.com/nette/tester/blob/master/src/Framework/DomQuery.php#L84 But I don't know correct code.

milo commented 9 years ago

I'm not a CSS guru, imho the value should be quoted like input[name="container[item]"]. If so, bug is still valid :o)

Proposed fix #236.

trejjam commented 9 years ago

Thanks @milo, works well