Closed enumag closed 3 years ago
@dg The failure is not caused by my changes.
Can you add a test?
The test would of course require ext-ds to be installed. I'm not sure how to add it on your GitHub Actions setup.
In this way: https://github.com/nette/latte/blob/master/.github/workflows/tests.yml#L20
(Probably extensions: ds
)
@dg How do I run the tests locally? I tried composer tester
but it fails with
Error: Interface 'JsonSerializable' not found
I have no idea why. I'm using json extension every day and in my code it always exists. So I'm very confused. Can you fix composer tester
so that it would work?
vendor/bin/tester -C tests
should do the job
@milo thx for the advice, I fixed composer.json to use this option too.
ad JsonSerializable: what operating system are you using?
@dg Ubuntu but I don't think it's important. The issue is that nette/tester isn't using the system's default php.ini without the -C
option so it didn't load any extensions. It is very counter-intuitive for someone not experienced with nette/tester.
If there are reasons to not load the default php.ini in some scenarios then in my opinion it should work the other way around - use system's php.ini by default with an option to turn it off.
The point is, it works for me on Windows and I had no idea there is such a problem.
This has to be solved with a custom php.ini, I'll fix it so please don't change the composer.json.
Alright, I removed the composer.json commit. Can you review the feature I'm adding? :-)
Looks good, thanks
Closes #472