Unlock session file before close

nette / tracy

😎 Tracy: the addictive tool to ease debugging PHP code for cool developers. Friendly design, logging, profiler, advanced features like debugging AJAX calls or CLI support. You will love it.

https://tracy.nette.org

Other

1.75k stars 218 forks source link

Unlock session file before close #540

Closed SendiMyrkr closed 2 years ago

SendiMyrkr commented 2 years ago

bug fix
BC break? no

There is a problem with locking when you use php to execute bash script with background processes eg. https://stackoverflow.com/questions/71929617/php-8-1-not-release-flock-after-calling-exec

Unlocking before fclose seems to be a solution.

dg commented 2 years ago

Did you run into any real locking problems with Tracy?

SendiMyrkr commented 2 years ago

Yes, example in SO link is part of my code. When i run script with it while i have enadbled tracy than other request freeze on flock in Tracy. I did kill php with that few times because limit of fcgi runs out.

dg commented 2 years ago

I understand. I'm glad I know that, because on Windows it behaves differently.