Closed janbarasek closed 1 year ago
This is a BC break, then file creation etc stops working.
@dg I fixed the editor URI string.
PhpStorm can do this?
Sure, you open an existing file. But it stops the file creation, editing and source mapping features of open-editor.js.
Or what it's good for &search=%search&replace=%replace
inside $editor = 'phpstorm://%action?file=%file&line=%line&search=%search&replace=%replace';
?
Sorry for the slower reply, I needed to thoroughly test all scenarios.
In the end, it looks like you can only send an action to PhpStorm via URL to open a file. So what about replacing the URI to only do the open
action? Even so, this will solve most of the common cases when working with dump data.
In a Linux environment or on a Mac, the default disk path to PhpStorm is always
/usr/local/bin/phpstorm
. This allows us to detect that PhpStorm is available and set the default path to the editor.At the same time, on a Mac, all we have to do is set the URI and the click-through works immediately.
This feature was inspired by the implementation in PhpStan Pro.