😎 Tracy: the addictive tool to ease debugging PHP code for cool developers. Friendly design, logging, profiler, advanced features like debugging AJAX calls or CLI support. You will love it.
We noticed when using the table sort that it would sort things alphabetically instead of numerically (if the field happened to start with a number). This fixes it while maintaining alphabetical sorting.
Improvement: Table sorting
BC break? no
doc PR: It's an internal fix that doesn't need to be documented
The problem we were running into is that we would have errors in our project sort like the following:
1x
1x
145x
2x
201x
3x
4x
etc.
It is the same for measuring database query times, etc. Anything numeric with text in it, it would kinda choke. Adding these couple extra arguments to the localeCompare() function allows it to sort numerics properly while maintaining alphabetical sorting.
BTW, looked for unit tests for your js stuff, but didn't find anything :grimacing:
We noticed when using the table sort that it would sort things alphabetically instead of numerically (if the field happened to start with a number). This fixes it while maintaining alphabetical sorting.
The problem we were running into is that we would have errors in our project sort like the following:
It is the same for measuring database query times, etc. Anything numeric with text in it, it would kinda choke. Adding these couple extra arguments to the localeCompare() function allows it to sort numerics properly while maintaining alphabetical sorting.
BTW, looked for unit tests for your js stuff, but didn't find anything :grimacing: