Server name from nette/http

nette / tracy

😎 Tracy: the addictive tool to ease debugging PHP code for cool developers. Friendly design, logging, profiler, advanced features like debugging AJAX calls or CLI support. You will love it.

https://tracy.nette.org

Other

1.75k stars 218 forks source link

Server name from nette/http #566

Closed janfejtek closed 1 year ago

janfejtek commented 1 year ago

new feature? yes
BC break? I don't think so

When using nette behind proxy or in containers, server name is localhost. When nette/http is used, it reads actual host from proxy headers - https://github.com/nette/http/blob/7a92a2a61aaf2ebb74df11bb4a6f56daf20a1ef6/src/Http/RequestFactory.php#L294

dg commented 1 year ago

A better way to do this is to allow the MailSender object to set $host directly, rather than passing the entire Request to it.

janfejtek commented 1 year ago

Is this ok?

dg commented 1 year ago

Great, thanks