TypeError in Strings::toAscii()

[strider2038]

Version: 3.1.1

Bug Description

iconv() https://github.com/nette/utils/blob/master/src/Utils/Strings.php#L167 returns false on some strings

TypeError: Return value of Nette\Utils\Strings::toAscii() must be of the type string, bool returned in /app/services/core/vendor/nette/utils/src/Utils/Strings.php on line 183

Steps To Reproduce

Original bug occurs when package was updated from 3.1.0 to 3.1.1 as a dependency for Easy Coding Standards library https://github.com/symplify/symplify/issues/1787

The problem occurs on Linux Alpine Docker image.

Expected Behavior

No type error

[dg]

On which string it returns false`

[strider2038]

/app/services/core - this is project directory. May be it is platform dependent?

[strider2038]

Also, there is warning

iconv(): Wrong charset, conversion from 'UTF-8' to 'ASCII//TRANSLIT//IGNORE' is not allowed

[strider2038]

It seems to be a problem with Linux Alpine image as it mentioned here https://github.com/nunomaduro/phpinsights/issues/43#issuecomment-492204530

But what about processing of iconv result? Is there any alternatives to iconv()? Or maybe check for false result can be added?

$converted = iconv('UTF-8', 'ASCII//TRANSLIT//IGNORE', $s);
if ($converted !== false) {
    $s = $converted;
}

[dg]

What is value of constant ICONV_IMPL?

[strider2038]

value is unknown

[dg]

Fixed

[strider2038]

Thanks! It now works perfectly. When will be a release?

[dg]

I think in about a week…

[strider2038]

@dg Hello! What about a release?