Fix compatibility with PHP 8 after "Treat namespaced names as single token" RFC - Githubissues

nette / utils

🛠 Lightweight utilities for string & array manipulation, image handling, safe JSON encoding/decoding, validation, slug or strong password generating etc.

https://doc.nette.org/utils

Other

1.98k stars 147 forks source link

Fix compatibility with PHP 8 after "Treat namespaced names as single token" RFC #229

Closed ondrejmirtes closed 4 years ago

ondrejmirtes commented 4 years ago

Version: nette/utils master on PHP 8 nightly

This RFC breaks Reflection class: https://wiki.php.net/rfc/namespaced_names_as_token This is how the tests fail: https://github.com/ondrejmirtes/utils/runs/924516761?check_suite_focus=true#step:5:54

This is a proof-of-concept fix: https://github.com/ondrejmirtes/utils/commit/e55a8dab6c7802e46c667a8d841e7aa0c4b001af

I'd send a PR but there are other build failures I'm not sure how you want fixed. Feel free to check out my branch: https://github.com/ondrejmirtes/utils/commits/php-8

dg commented 4 years ago

Merged, thanks