Sync 4.1 - Githubissues

netty-contrib / handler-pcap

Capture data and write into Pcap format which helps in troubleshooting.

Apache License 2.0

6 stars 2 forks source link

Sync 4.1 #1

Closed yawkat closed 2 years ago

yawkat commented 2 years ago

I manually copied over the changes in 4.1:

https://github.com/netty/netty/commit/54a2c6da44f57c1a8a721226165a7bb0a55beb8c
https://github.com/netty/netty/commit/7bae6a7a13c3bc6406d49f638e5952cc2644342b

There were a few merge conflicts, but the tests pass so I hope I didn't miss anything :) I'd appreciate someone looking over them though, in particular the server setup in the tests, since that API changed in 5.0.

chrisvest commented 2 years ago

The build is broken because this repo hasn't been migrated to the new APIs. I say we merge this and then migrate and restore the build as a separate task.