netty / netty-incubator-codec-http3

Experimental HTTP3 codec on top of QUIC
Apache License 2.0
170 stars 35 forks source link

Change API of Http3RequestStreamInboundHandler to better handle FIN #240

Closed normanmaurer closed 1 year ago

normanmaurer commented 1 year ago

Motivation:

5740c520bbabd490a448c97a4b8f0574115b68f6 introduced a workaround for correctly handle FIN when multiple http3 frames are contained in one QUIC frame. While this worked it was kind of hacky and we should better adjust the API.

Modifications:

Result:

Better fix for handling multiple frames

normanmaurer commented 1 year ago

@yawkat WDYT ?

normanmaurer commented 1 year ago

it's a bit annoying that we cant coalesce FullHttpRequest anymore but i guess that's not doable without buffering

yeah... that said I think its most likely not a big deal and the API / implementation seems a bit better this way.

normanmaurer commented 1 year ago

@yawkat btw I am happy if you have any better idea :)

yawkat commented 1 year ago

i don't :)