search

netty / netty-incubator-codec-quic

Apache License 2.0
300 stars 70 forks source link

Only create a new QuicChannel when receiving an INITIAL packet #720

Closed normanmaurer closed 3 months ago

normanmaurer commented 3 months ago

Motivation:

We should only try to create a new QuicChannel when receiving an INITIAL packets. For all the other packets we want to just drop the packet on the floor if there is no existing mapping.

Modifications:

Only create a new QuicChannel on receiving an INITAL packet

Result:

Correctly handle creation of new QuicChannel

normanmaurer commented 3 months ago

/cc @ehaydenr

ehaydenr commented 3 months ago

This lgtm, but it's still not clear to me why the old code didn't work

normanmaurer commented 3 months ago

@ehaydenr this is not really related. Just something that I found while debugging.