netty / netty-tcnative

A fork of Apache Tomcat Native, based on finagle-native
Apache License 2.0
241 stars 179 forks source link

Stop cancelling build matrix when one build fails #868

Closed normanmaurer closed 7 months ago

normanmaurer commented 7 months ago

Motivation:

Motivation: We unfortunately have a number of flaky tests haunting our builds. The GHA build matrix will by default cancel all matrix jobs when one job experiences a failure. This is unproductive with flaky tests, because the more failed builds that need to rerun, the higher the chances of more failures. Also, seeing builds pass on other JVM versions helps build confidence, even if other versions failed on a flaky test.

Modification: Disable fail-fast on matrix-strategy builds.

Result: Jobs in a matrix build no longer get cancelled if a sibling-job fails.