search

netty / netty-tcnative

A fork of Apache Tomcat Native, based on finagle-native
Apache License 2.0
241 stars 179 forks source link

Drop support for windows #897

Open normanmaurer opened 3 weeks ago

normanmaurer commented 3 weeks ago

I propose to drop support for windows and just focus on linux / macOS. Users of windows can just use the JDK implementation for SSL

normanmaurer commented 3 weeks ago

/cc @vietj @slandelle @trustin @chrisvest @ejona86 @franz1981

franz1981 commented 3 weeks ago

I am not aware of anything bad with it, but let me summon @cescoffier here

cescoffier commented 3 weeks ago

+1

normanmaurer commented 3 weeks ago

/cc @violetagg

slandelle commented 3 weeks ago

I’m fine with it. What’s less work for you.

violetagg commented 3 weeks ago

+1

ejona86 commented 3 weeks ago

CC @matthewstevenson88 @rmehta19

ejona86 commented 3 weeks ago

CC @kannanjgithub

vietj commented 3 weeks ago

@normanmaurer I'm fine with that

chrisvest commented 3 weeks ago

I'm biased, but I'm in favor. We already don't support any native transports for Windows.

zekronium commented 6 days ago

Isin't the windows JDK implementation much worse performance wise than BoringSSL?

normanmaurer commented 5 days ago

@zekronium maybe ? Honestly I don't know ... That said no-one of our core developers has any use-case for windows so I feel we should better invest our energy in things that matter to us :)

normanmaurer commented 5 days ago

@ejona86 so any concerns from the GRPC side or not ?

trustin commented 5 days ago

I'm fine with dropping Windows support, but I'm curious about why. Is it because of complex build and release process?

zekronium commented 5 days ago

Windows seems least complex to build atleast for me. What is windows specific here that requires/required significant amount of maintenance work?

normanmaurer commented 5 days ago

It's more about that if something does not work no-one will be able to fix it...

zekronium commented 5 days ago

Has that happened?