search

netty / netty

Netty project - an event-driven asynchronous network application framework
http://netty.io
Apache License 2.0
33.09k stars 15.82k forks source link

NetBSD support #10809

Open krytarowski opened 3 years ago

krytarowski commented 3 years ago

Expected behavior

Build and work on NetBSD.

Actual behavior

Not working on NetBSD.

Steps to reproduce

Try to build in pkgsrc-wip with these build rules:

https://wip.pkgsrc.org/cgi-bin/gitweb.cgi?p=pkgsrc-wip.git;a=commitdiff;h=216b86d9ff25fb21af74d56ca1f45afe87031aab

Package is called 'java-netty'.

The package is inspired by FreeBSD's ports package for the same software.

Minimal yet complete reproducer code (or URL to code)

https://wip.pkgsrc.org/cgi-bin/gitweb.cgi?p=pkgsrc-wip.git;a=blob;f=java-netty/files/patch-netty_kqueue_bsdsocket.c;h=130c5bf49a2bedf8be46ba489d1e2c7476b792f1;hb=216b86d9ff25fb21af74d56ca1f45afe87031aab

  1. TCP_NOPUSH is unsupported
  2. sendfile() is unsupported
  3. netty_kqueue_bsdsocket_getPeerCredentials needs a custom implementation

Does this patch looks good? At minimum, the 1-3 problems have to be fixed.

Netty version

4.1.53

JVM version (e.g. java -version)

https://pkgsrc.se/lang/openjdk11

openjdk11 version 1.11.0.9.11

OS version (e.g. uname -a)

NetBSD/amd64 9.99.x

normanmaurer commented 3 years ago

@krytarowski thanks for the report but this will not be good enough IMHO as you just remove the C bindings but it may still be called from the java layer. Consider opening a PR with the changes and we can work from there to get it fixed.

krytarowski commented 3 years ago

@normanmaurer OK, I'm not a java developer so I need assistance.