search

netty / netty

Netty project - an event-driven asynchronous network application framework
http://netty.io
Apache License 2.0
32.88k stars 15.75k forks source link

[discuss] update slf4j to 2.x in 4.2 branch #14011

Closed shoothzj closed 2 weeks ago

shoothzj commented 3 weeks ago

Slf4j 1.7 has not been maintained for almost 2 years. Shall we update slf4j to 2.x in 4.2 branch? I am willing to send a PR. :)

@normanmaurer @chrisvest

shoothzj commented 3 weeks ago

ping @normanmaurer @chrisvest

normanmaurer commented 3 weeks ago

@shoothzj is slf4j 2.x api compatible with slf4j 1.x ? or does it use different package names ?

slandelle commented 3 weeks ago

@normanmaurer Yes it is. The only "issue" is that users have to upgrade their implementation (eg logback) as well because they've changed the discovery mechanism.

shoothzj commented 3 weeks ago

@normanmaurer Yes, It's compatible. And I have update in other project. https://github.com/apache/bookkeeper/pull/4248

Log4j just update minor version. Logging configuration files don't need to change.

SLF4J API version 2.0.0 requires Java 8 and introduces a backward-compatible fluent logging API. By backward-compatible, we mean that existing logging frameworks do not have to be changed in order for the user to benefit from the fluent logging API.

normanmaurer commented 3 weeks ago

I think that's fine... please send over a PR :)