search

netvl / xml-rs

An XML library in Rust
MIT License
461 stars 113 forks source link

Attempted to fix the parsing as characters of ]]> and ?> #195

Closed jdalberg closed 3 years ago

jdalberg commented 4 years ago

I was playing around with xml-rs in my own project (https://github.com/jdalberg/cwmp) and decided to use QuickCheck for validation. So a bunch of randomness into fields, generate some xml, parse it and compare with input with different permutation of content, and came across what I consider to be a bug in the parser. It would not recoqnice: "?>" as characters.

Looking into xml-rs i could see that in line 127 of reader/lexer.rs the token for "?>" was missing from the function, looking at issue #32 i introduced two new testcases and the two tokens for "]]>" and "?>" in the list of token that are possibly characters.

daemontus commented 3 years ago

Hi, @netvl - are there any plans for merging/publishing this soon? :) We have a few projects which we would like to push to crates.io, but our users rely on this fix quite often (we work with biological models which are encoded as XML but sometimes contain embedded escaped HTML with formatted text) and we thus have a git dependency on this PR instead of original xml-rs. Is there something else that is needed for this to be merged?

bryanburgers commented 3 years ago

@jdalberg Thank you! You're awesome.

netvl commented 3 years ago

@jdalberg @daemontus I'm very sorry for the lack of activity, but currently I simply don't have capacity to work on xml-rs anymore :( I should publish a call for a new maintainer somewhere, but I can't find time to even do that :(

This change looks good, I'll merge it. Thank you very much!

daemontus commented 3 years ago

No worries! Thank you for all your work and time! :)

Probably a disclaimer in the readme that the crate is not actively maintained would be enough so that people know to adjust expectations. Anyway, my time management also isn't the greatest, but if you need I could help with basic maintenance. At the moment I am using a lot of Rust so it shouldn't be a huge context switch for me :D

netvl commented 3 years ago

Yes, I will certainly update the readme, I should've done that long ago.

Thanks for your suggestion, I really appreciate it but at this point, I guess I have to look for a maintainer who would be able to take over the project completely, since I can alot close zero time to further work on xml-rs :(