netwerk-digitaal-erfgoed / ld-workbench

A CLI tool for transforming large RDF datasets using pure SPARQL.
5 stars 1 forks source link

Unit tests for utilities and classes #5 #14

Closed philipperenzen closed 11 months ago

philipperenzen commented 11 months ago

@mightymax there are some issues with the .run() tests for Stage, Iterator, and Generator classes. These tests worked before, but now seem to fail and not produce any data (no code was changed regarding the workings of these classes and they work as expected, but not in the unit test).

Also noticed the Stage class's this.generator does not emit the this.emit('generatorResult', quadCount) - I added a comment for this in the class, I did notice it would slow down my test a bit, also the expected results would change if this is emitted.

7 can be closed when a pipeline is started once this MR is reviewed and accepted.