netwerk-digitaal-erfgoed / makemyflix

Make your own Heritageflix
0 stars 0 forks source link

Create developper documentation #17

Closed EnnoMeijers closed 2 weeks ago

EnnoMeijers commented 1 month ago

For geting more developpers to start working on this code we should provide developper documentation and give instructions how to run this sofware in local configuration.

EnnoMeijers commented 2 weeks ago

@aabelmann Thanks for updating the developer documentation, this helps a lot! Would it be possible to run a local setup also with a local storage instead of an S3 bucket? This could lower the barrier for noobs like me that are not very familiar with S3 configuration.

aabelmann commented 2 weeks ago

@EnnoMeijers We can but I'm worried it would cause for more confusion.

The way we have set it up now, is that docker-compose will setup a S3 bucket (using minio) and if you use .env.example as your own .env file, you should be able to start without any extra configuration. (if that isn't the case, please let me know)

To clarify Minio is running a S3 bucket locally, so it's also writing to your local storage. In our case the folder called "minio-data", which contains all the files you uploaded.

If you do want to run it without a S3 bucket, the following needs to be done:

This will make Strapi write directly to the folder "public/upload".

Adding this as an option to the current setup would make the configuration more complicated and convoluted. And since it doesn't really offer a benefit, I would prefer to not add it.

EnnoMeijers commented 2 weeks ago

Ah, thanks for the clarification, based on the technical requirements section my impression was that an AWS-S3 bucket needed to be created before starting the docker container. I will do some more testing and come back to it.

EnnoMeijers commented 2 weeks ago

Looking good now, closing this issue!