search

netwerk-digitaal-erfgoed / network-of-terms

Search engine for finding terms in terminology sources (such as thesauri, classification systems and reference lists)
https://termennetwerk-api.netwerkdigitaalerfgoed.nl
European Union Public License 1.2
17 stars 3 forks source link

Rijksmonumenten search #1422

Closed rschalkrce closed 3 weeks ago

rschalkrce commented 2 months ago

A user remarked that he cannot find the URI of a certain Rijksmonument while searching on its identifier 486800. It is in the data.

Alternatively, searching on addressLocality in the demonstrator will not help, because of the LIMIT in the query.

@ddeboer can we fix this in the query, perhaps by adding schema:address in the VALUES, or by manipulating the string for the identifier - keeping in mind we don't want longer response times?

ddeboer commented 3 weeks ago

We already search the schema:identifier, so I can find the resource that way. However, the resource has no schema:name and is therefore not returned from the query, which assumes that property.

@rschalkrce Is schema:name optional or is this a faulty resource?

rschalkrce commented 3 weeks ago

@ddeboer You're right, schema:name should be optional in the Rijksmonumenten queries. Can you fix that? (That's probably quicker than me making another branch for these simple edits.)

ddeboer commented 3 weeks ago

:tada: This issue has been resolved in version 9.16.4 :tada:

The release is available on npm package (@latest dist-tag)

Your semantic-release bot :package::rocket: