network-analytics / mdt-dialout-collector

Model-Driven Telemetry - Collecting <multi-vendor> metrics via gRPC dialout
MIT License
27 stars 8 forks source link

Code: recommend to rename struct Payload to avoid namespace conflicts #18

Closed paololucente closed 1 year ago

paololucente commented 1 year ago

In src/bridge/grpc_collector_bridge.h it is defined struct Payload. Such naming is very generic and, when used in 3rd party tools (ie. pmacct), it may be source of namespace conflicts. I would recommend to rename it to something more specific, ie. grpcPayload or something like that.

    typedef struct {
        char *event_type;
        char *serialization;
        char *writer_id;
        char *telemetry_node;
        char *telemetry_port;
        char *telemetry_data;
    } __attribute__ ((packed)) Payload;
scuzzilla commented 1 year ago

renaming done.