Closed fluvf closed 5 years ago
package.json
, to partially enforce a minimum NodeJS version. Keeping the readme updated with a Requirements
part should also help..vscode
folder holds workspace specific configurations files. And unless the agreed upon editor for the entire project is VSCode I don't think it should be included in the source..gitignore
. There probably should be an issue added for replacing it with a build process later onRebased and addressed your comments. Do you think the banner that was added in 7b1e18a is a good enough note about the coding rules?
Ok, I did some more research about the .vscode
folder and changed my opinion about removing it. Sorry this has been a bit of a process :D
I think only two files should be allowed in there, extensions.json
and tasks.json
. But instead of removing launch.json
and settings.json
a .default
suffix would be added onto them.
I don't think enforcing workspace settings onto others is a good idea, but I can see how the file exclusions would be necessary for the time being.
I'd also think most have / want to have their own debugging commands, but offering sensible defaults might give an easier start.
But as this is a bit of an opinionated pull request, I split it into three parts:
semistandard
changesDid another rebase
Rebased
Getting this merged would be great, as it would automate much of my workflow
(also I will keep rebasing this until you either merge it or say no)
Thanks!
I feel like the semistandard (and the standard) package is a good fit to the coding style of this project, and as it's a well maintained project, it'll lift the need to worry about maintaining eslint. Also includes a fix for the
npm run *
commands