networkcobwebs / minecraft-server-manager

Minecraft Server Manager
Apache License 2.0
23 stars 7 forks source link

Package: Replace custom eslint with semistandard #30

Closed fluvf closed 5 years ago

fluvf commented 5 years ago

I feel like the semistandard (and the standard) package is a good fit to the coding style of this project, and as it's a well maintained project, it'll lift the need to worry about maintaining eslint. Also includes a fix for the npm run * commands

fluvf commented 5 years ago
fluvf commented 5 years ago

Rebased and addressed your comments. Do you think the banner that was added in 7b1e18a is a good enough note about the coding rules?

fluvf commented 5 years ago

Ok, I did some more research about the .vscode folder and changed my opinion about removing it. Sorry this has been a bit of a process :D

I think only two files should be allowed in there, extensions.json and tasks.json. But instead of removing launch.json and settings.json a .default suffix would be added onto them. I don't think enforcing workspace settings onto others is a good idea, but I can see how the file exclusions would be necessary for the time being. I'd also think most have / want to have their own debugging commands, but offering sensible defaults might give an easier start.

But as this is a bit of an opinionated pull request, I split it into three parts:

fluvf commented 5 years ago

Did another rebase

fluvf commented 5 years ago

Rebased

fluvf commented 5 years ago

Getting this merged would be great, as it would automate much of my workflow

(also I will keep rebasing this until you either merge it or say no)

fluvf commented 5 years ago

Thanks!