networkcobwebs / minecraft-server-manager

Minecraft Server Manager
Apache License 2.0
23 stars 7 forks source link

Web UI should report when Java is not installed #54

Open nickrnet opened 5 years ago

nickrnet commented 5 years ago

Right now if a machine does not have Java installed, the Minecraft server jar can be installed, but never executed. The web UI needs to reflect that either by displaying a warning or allowing a Java installation (OpenJDK, Amazon Coretto, etc.).

We should probably prevent installation if a JRE is not installed.

Automatic installation gets hairy if we want to prompt for a local installation path (unzip) vs. using an OS package (brew on OSX, Linux package manager, and not sure what to do on Windows). Or we can find a suitable JRE that allows it to be npm installed (https://github.com/raftario/njre is one) and use it. https://www.npmjs.com/package/node-jre is older but also a contender.

Installing Java could require a MSM restart, or we can adjust the MinecraftServer code to reload the JAVA_HOME as needed as a requirement for this to be done, but more than likely that is an additional enhancement.