networked-aframe / naf-janus-adapter

networked-aframe Janus network adapter
Mozilla Public License 2.0
12 stars 9 forks source link

Update janus docker image #62

Closed vincentfretin closed 6 months ago

vincentfretin commented 8 months ago

Notes from an audit report:

Binary is compiled with debug sections. Those should be stripped (CWE-215). libusrsctp.so.2.0.0 libjanus_plugin_sfu.so libjanus_websockets.so.0.0.0 libjanus_pfunix.so.0.0.0 libjanus_http.so.0.0.0 libnice.so.10.11.0 janus

Binary is compiled with assert() statements. Those should be removed (CWE-617). libwebsockets.so.19 libnice.so.10.11.0

FULL RELOCATIONS libsrtp2.so.1 libusrsctp.so.2.0.0 libwebsockets.so.19 libjanus_websockets.so.0.0.0 libjanus_pfunix.so.0.0.0 libjanus_http.so.0.0.0 libnice.so.10.11.0

FORTIFY CWE 693 : Lack of Hardening libwebsockets.so.19 libjanus_plugin_sfu.so libjanus_websockets.so.0.0.0 libjanus_pfunix.so.0.0.0 libjanus_http.so.0.0.0 janus

https://wiki.debian.org/Hardening search for "Notes for packages using CMake" so probably add the following flags: gcc -D_FORTIFY_SOURCE=2 -O1

vincentfretin commented 6 months ago

done in https://github.com/networked-aframe/janus-plugin-sfu/pull/11