search

networked-aframe / naf-janus-adapter

networked-aframe Janus network adapter
Mozilla Public License 2.0
12 stars 9 forks source link

add getLocalMediaStream and remove old Firefox workaround #71

Closed arpu closed 6 months ago

vincentfretin commented 6 months ago

replaceTrack is really returning a Promise. I think the await was needed for the firefox workaround setting t.enabled after the track was successfully replaced. If you remove the await here, then you need to remove the firefox workaround. The workaround is not needed since a long time.

Was there any specific reason you changed the api here, perf?

arpu commented 6 months ago

Hey sorry i should add this as Draft, had some problems with the await on recreate a Video Stream

vincentfretin commented 6 months ago

Ok for the getLocalMediaStream() api and removing the firefox workaround for replaceTrack, but I think we need to keep the async await for setLocalMediaStream here.

vincentfretin commented 6 months ago

I'm also using await in this code https://github.com/networked-aframe/naf-valid-avatars/blob/3ea483e3cd32974b8ee5dfc25a4a1b6add3bd3e4/src/ShareScreenButton.tsx#L123 so that's a breaking code.

arpu commented 6 months ago

done