search

networked-aframe / naf-valid-avatars

Example of using realistic animated avatars in networked-aframe.
https://naf-valid-avatars.glitch.me
MIT License
10 stars 0 forks source link

Simplify simple-navmesh-constraint integration #28

Closed vincentfretin closed 4 months ago

vincentfretin commented 6 months ago

The integration of simple-navmesh-constraint I did in #26 could be better. I'm waiting 2s before setting the component because the component doesn't listen for child-attached/child-detached events like aframe-blinks-controls for example to update the entities to check. It only does it in update.

See also

Probably create the new repository first and do a change there to support child-attached/child-detached events.

vincentfretin commented 5 months ago

In https://github.com/networked-aframe/naf-valid-avatars/commit/57518093e1df6c49b2b66d5ad99e2dbf41e69343 I moved navigation-start/navigation-end events to disable/enable simple-navmesh-constraint in player-info, character-controller will be removed once I do the required changes in simple-navmesh-constraint

vincentfretin commented 5 months ago

Also simplify https://github.com/c-frame/aframe-gltf-model-plus search for simple-navmesh-constraint and remove some lines of code. This also would make gltf-model-plus agnostic to the navmesh solution if you're using in your project simple-navmesh-constraint or aframe-extras nav-mesh with movement-controls="constrainToNavMesh: true"

vincentfretin commented 4 months ago

With https://github.com/AdaRoseCannon/aframe-xr-boilerplate/pull/27 merged I can now remove the character-controller component completely.